Skip to content

Commit 1a0e8fc

Browse files
committed
resolving merge conflicts
2 parents 2242ea6 + d799f54 commit 1a0e8fc

File tree

6 files changed

+51
-33
lines changed

6 files changed

+51
-33
lines changed

README.md

+33-20
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,49 @@
11
# Cat Clicker
2-
This is a simple JavaScript app that keeps track of the number of clicks while on the selected photo. You may choose between five different cat photos. Once you switch to another photo your click count is lost (for now).
2+
3+
This is a simple JavaScript app that keeps track of the number of clicks while on the selected photo. You may choose between five different cat photos. Once you switch to another photo your click count is lost (for now).
34

45
The live, playable game can be found [here](https://js-goose.github.io/cat-clicker/).
56

67
# Project Design
7-
I chose something simple and easy on the eyes as I'm not the best designer. I feel as though the layout works well and has a natural flow to it.
8+
9+
I chose something simple and easy on the eyes as I'm not the best designer. I feel as though the layout works well and has a natural flow to it.
10+
11+
# Example of Play
12+
13+
![alt text](https://github.com/mepda/cat-clicker/blob/master/img/example.png?raw=true)
814

915
# Playing Locally
16+
1017
Fork or download the repo and once saved locally open up `index.html` in your favorite browser.
1118

1219
# Instructions
13-
* On load, the image displayed is a placeholder and will not count clicks
14-
* Choose a cat from the left menu
15-
* Click on the photo of your selected cat to incriment your count
16-
* Count is not reset upon selecting another cat
1720

18-
# Required Dependencies
19-
* There are no required dependencies.
21+
- On load, the image displayed is a placeholder and will not count clicks
22+
- Choose a cat from the left menu
23+
- Click on the photo of your selected cat to incriment your count
24+
- Count is not reset upon selecting another cat
25+
26+
# Required Dependencies
2027

21-
# Optional Dependencies
22-
* There are no optional dependencies.
28+
- There are no required dependencies.
29+
30+
# Optional Dependencies
31+
32+
- There are no optional dependencies.
2333

2434
# Pull Requests
25-
I am the only contributor to this code (besdies the aforementioned credited sources) and the project is complete (I think). There's not much to this project but if you feel the desire to contribute I won't say no.
2635

27-
# Licensing
36+
I am the only contributor to this code (besdies the aforementioned credited sources) and the project is complete (I think). There's not much to this project but if you feel the desire to contribute I won't say no.
37+
38+
# Licensing
39+
2840
This project is licensed under the [MIT License](https://github.com/JS-goose/cat-clicker/blob/master/LICENSE) and you are **free** to do the following with the code, subject to the conditions provided within the license found at the link above:
29-
* use
30-
* copy
31-
* modify
32-
* merge
33-
* publish
34-
* distribute
35-
* sublicense
36-
* sell
41+
42+
- use
43+
- copy
44+
- modify
45+
- merge
46+
- publish
47+
- distribute
48+
- sublicense
49+
- sell

css/normalize.css

+2-7
Original file line numberDiff line numberDiff line change
@@ -123,16 +123,11 @@
123123
line-height: 0;
124124
position: relative;
125125
vertical-align: baseline;
126-
}
127-
128-
sub {
129126
bottom: -0.25em;
130-
}
131-
132-
sup {
133127
top: -0.5em;
134128
}
135129

130+
136131
/* Embedded content
137132
========================================================================== */
138133

@@ -342,4 +337,4 @@
342337
[hidden] {
343338
display: none;
344339
}
345-
340+

css/style.css

+10-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,15 @@
3131
grid-area: aside;
3232
grid-row: 2 / span 2;
3333
justify-content: center;
34+
/* The .catSelection itself is the `aside` in the .wrapper grid above. If the
35+
* value below is `center`, this will shift up and down as the `content` grid
36+
* section adjusts in height, e.g. the photo for Bethany is taller, ergo this
37+
* section will shift down.
3438
align-content: center;
39+
*
40+
* a value of `start` will keep this flush top.
41+
*/
42+
align-content: start;
3543
}
3644
.catSelection h1, ul {
3745
padding: 20px;
@@ -40,6 +48,7 @@
4048
.catSelection li {
4149
text-align: center;
4250
padding: 5px;
51+
border: 1px solid transparent;
4352
}
4453
.catItem:hover {
4554
background-color: var(--link-blue);
@@ -121,8 +130,6 @@ a {
121130
landscape view on smaller phones.
122131
Larger phones will still get the desktop version on landscape) */
123132

124-
/* completed fir first PR for hacktoberfest */
125-
126133
@media only screen and (max-width: 768px) {
127134
.wrapper, .catSelection {
128135
display: block;
@@ -170,4 +177,4 @@ Larger phones will still get the desktop version on landscape) */
170177
.trademark h2, #social {
171178
font-size: 1rem;
172179
}
173-
}
180+
}

img/example.png

1.41 MB
Loading

img/maxresdefault.jpg

339 KB
Loading

index.html

+6-3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@
1010
<meta charset="utf-8">
1111
<meta http-equiv="X-UA-Compatible" content="IE=edge">
1212
<title>Cat Clicker!</title>
13-
<meta name="description" content="">
14-
<meta name="viewport" content="width=device-width, initial-scale=1">
13+
14+
<meta name = "keywords" content = "Cat Clicker, Simple Javascript app, Cat photo click count" />
15+
<meta name = "description" content="This is a simple JavaScript app that keeps track of the number of clicks on the selected photo.">
16+
<meta name = "author" content = "JS-goose" />
17+
<meta name ="viewport" content="width=device-width, initial-scale=1">
1518
<link rel="stylesheet" href="./css/style.css">
1619
<link rel="stylesheet" href="./css/normalize.css">
1720
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.2.0/css/all.css" integrity="sha384-hWVjflwFxL6sNzntih27bfxkr27PmbbK/iSvJ+a4+0owXq79v+lsFkW54bOGbiDQ"
@@ -93,4 +96,4 @@ <h2>Built by me,
9396
</section>
9497
</body>
9598

96-
</html>
99+
</html>

0 commit comments

Comments
 (0)