Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitForEnabled (maybe others?) not always properly waiting #136

Open
PandaMagnus opened this issue Jan 2, 2025 · 1 comment
Open

WaitForEnabled (maybe others?) not always properly waiting #136

PandaMagnus opened this issue Jan 2, 2025 · 1 comment

Comments

@PandaMagnus
Copy link
Contributor

I made some assumptions on nested stack traces, and certain methods (WaitForEnabled and possibly others,) improperly throw instead of waiting and then returning true/false.

Need to do a bit of investigation, but it should be safe to remove the exception filters that check for inner stack traces.

@PandaMagnus
Copy link
Contributor Author

I see what happened. The element selector was incorrect, so no element was found. This is likely correct behavior, but may come down to expectations. If the element doesn't exist, perhaps WaitForEnabled/Disabled should still return false instead of throwing? I'll ask around for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant