Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Memory leak from dependency @mapbox/node-pre-gyp #417

Open
phpdave opened this issue Feb 11, 2025 · 1 comment
Open

[BUG] Memory leak from dependency @mapbox/node-pre-gyp #417

phpdave opened this issue Feb 11, 2025 · 1 comment
Assignees

Comments

@phpdave
Copy link

phpdave commented Feb 11, 2025

Describe your system

  • odbc Package Version: 2.4.9
  • Database Name: os400
  • Node.js Version: 20.18.2
  • Node.js OS: IBM i

Describe the bug
npm install odbc warns of a memory leak

Image

Image

Expected behavior
No memory leaks and use latest version based on this comment that 2.0.0 has fixed this
mapbox/node-pre-gyp#877 (comment)

To Reproduce

npm install odbc
@phpdave phpdave changed the title [BUG] [BUG] Memory leak from dependency @mapbox/node-pre-gyp Feb 11, 2025
@kadler
Copy link
Member

kadler commented Feb 11, 2025

Thanks for bringing this to our attention again. Until 2.0 was published 17 days ago, there was nothing we could do about this. However, node-pre-gyp is only used during install time (to download pre-built binaries, if available), so memory leaks are unlikely to cause much problems.

Now that 2.0 is out, we can work on upgrading, however due to the major version bump to 2.0, it requires more care to evaluate. Potentially this is just because they bumped minimum Node requirement to 18.0? We'll have to do more testing to see what shakes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants