Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] For the loader installation screen in different scenarios, it is hoped that different translations will be used for the not installed state #3297

Open
3gf8jv4dv opened this issue Sep 25, 2024 · 0 comments · May be fixed by #3624
Open

[Bug] For the loader installation screen in different scenarios, it is hoped that different translations will be used for the not installed state #3297

3gf8jv4dv opened this issue Sep 25, 2024 · 0 comments · May be fixed by #3624
Labels
bug

Comments

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented Sep 25, 2024 •
edited
Loading

平台 | Platform

Windows 11

问题描述 | Problem Description

f8d7c92 in main branch.

In both scenarios described in the title, it seems that the same i18n key is used for translate "not selected", and the same code is used. This prevents me from adjusting their translations individually.

I would like to be able to translate this to "Do not install" and "Not installed" respectively.

Preview

hmcl-loader-installation-screen-1

hmcl-loader-installation-screen-2

启动器崩溃报告 / 启动器日志文件 | Launcher Crash Report / Launcher Log File

N/A
@3gf8jv4dv 3gf8jv4dv added the bug label Sep 25, 2024
@3gf8jv4dv 3gf8jv4dv changed the title [Bug] For the loader insallation screen in different scenarios, it is hoped that different translations will be used for the not installed state [Bug] For the loader installation screen in different scenarios, it is hoped that different translations will be used for the not installed state Sep 25, 2024
@3gf8jv4dv 3gf8jv4dv linked a pull request Feb 18, 2025 that will close this issue
Open
3gf8jv4dv added a commit to 3gf8jv4dv/HMCL that referenced this issue Feb 18, 2025
@3gf8jv4dv
fix(i18n): show installable translations according to different styles
fd73b9e 
when install a new instance (安装新游戏): Do not install (不安装)
on Edit Instance → Loaders (自动安装页面): Not installed (未安装)

resolves HMCL-dev#3297
3gf8jv4dv added a commit to 3gf8jv4dv/HMCL that referenced this issue Mar 6, 2025
@3gf8jv4dv
fix(i18n): show installable translations according to different styles
dab8257 
when install a new instance (安装新游戏): Do not install (不安装)
on Edit Instance → Loaders (自动安装页面): Not installed (未安装)

resolves HMCL-dev#3297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): show installable translations according to different styles 3gf8jv4dv/HMCL
1 participant
@3gf8jv4dv