-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design v1 of the Plugin Registry site #661
Comments
FYI @osamajandali apparently, according to @narekhovhannisyan , https://github.com/NodeSecure/npm-registry-sdk will give you all the stats. This is in reference to the first AC on this issue. |
@jmcook1186 here's a good place for you to let @osamajandali know about the repo you created #614 :) |
hi @osamajandali - just to let you know this repo exists and should be the home for plugin registry website source code eventually. |
Capturing the status in the weekly call: this is yet to be started as @osamajandali was delayed in returning from his vacation |
@osamajandali looking really awesome!! 🙏 |
Wow looks great @osamajandali! |
@jawache @jmcook1186 (cc @osamajandali ) I love the design, and all is super cool, only unclear if the "official plugin" badge should be as explicitly stating that it's an official plugin or something more subtle to show endorsement that would also allow highlighting external plugins? |
Love the design - really no criticism of how the page looks at all. I will have some comments about the content of the cards - we haven't provided any guidance on that so far, but I anticipate each card containing:
|
@jmcook1186 noted, we've seen that we are missing publisher name which we'll add and we'll remove the words "official plugin" form the badge and keep it as a tooltip where the copy can be updated to match what it will be. Can we clarify why we need |
Yes- this still needs to be confirmed with @jawache but I'm anticipating that users will be able to raise PRs against the registry repository to add plugins to the site. When they do so, they will have to fill out a simple issue form that asks them some basic questions about their plugin:
The answers accelerate the core team's ability to judge the PR quickly and do some minimal QA, but we also want visitors to the site to be able to click from the card on the site to the author's responses on the issue form as a shortcut for the community to do their own due diligence before installing the plugins. |
Hey so @jmcook1186 I was thinking for this MVP we match the functionality of the gulp registry. Each card is linked to one place, either the npm or GitHub if there is no npm link. Its a good idea to insist the plugins report some common info, but I'd argue they have to list that clearly on the plugin landing page in npm/gh, rather than document it in the PR itself. We can just check their npm landing page to make sure it's.there as we expect. I'm also ok with the process of submitting being that they edit the JSON file that powers the registry, add their info, have PR check boxes like you say but the actual answers should be on their plugin landing page. We review to make sure they match our requirements, then all we have to do is accept the PR and it will be added to the registry. |
sure - I just want a user to be able to tell at a glance whether a plugin meets our basic set of requirements. The form can literally just be a set of checkboxes with the actual information being in the GH repo or npm page. I also anticipated a PR being a new entry to the json file. |
In that case not sure if there is a ticket for this, but as well as the plugin registry we'll also need some docs to explain the process and minimum requirements for the plugin (docs/landing page etc...) To make life easier we can add it to if-docs, or create a page in our Notion wiki, whatever is easiest. |
@jawache - we have #634 for documenting etc. In the design there are multiple links supported, so we can add all links that are needed. |
Json referred to the other task #684 |
Why: sub of #633
What: Design for MVP of plugin registry
Scope of work:
The text was updated successfully, but these errors were encountered: