-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-importer
in pipeline ignores defaults and input parameter values in its outputs
#81
Comments
To summarize, what we observed is that with |
azure-importer
in pipeline causes **defaults** section values to be processed in strange waysazure-importer
in pipeline ignores defaults and input parameter values in its outputs
Hi @pangteckchun thanks for the detailed report - we will look over it in our bug triage call this week and see if there is a quick fix we can push for you. It looks like the importer did not get upgraded when we introduced the However, we're currently thinking about the right home for the azure importer - we had a team of Azure pro's who built an updated version for us as part of the hackathon and we will most likely make theirs the "canonical" version in the next couple of weeks. |
Hi James, thanks for acknowledging this. The reason is because this plug-in is a key first step in my pipeline which allows us to showcase getting our Azure-based apps SCI in near real-time basis (depending on the timestamp and duration as input params). Unfortunately there is no way for me to workaround this bug (missing I am happy to hear any suggestions to make progress on this :) Cheers! |
Hi - yes, we need to make the importer respect the I'm tagging @zanete @narekhovhannisyan and @manushak for visibility - if some dev time becomes available then please confirm my diagnosis of the bug and push a fix to unblock @pangteckchun. Otherwise please prioritise in next sprint. |
Hi @pangteckchun, we are looking into this and it's planned for the current list of todos. We hope that we have some capacity to implement this fix this week which we'll find out by Wednesday this week. Thanks so much for your understanding! |
@narekhovhannisyan please review |
Hey, sorry to reply to a closed issue. Any chance I can have some reference/link to this other version of the azure importer? |
Hi @cvallesi-kainos you can find it here https://github.com/microsoft/azure-carbon-estimator |
Description of the Error
We tested and confirmed the inclusion of
azure-importer
plug-in causes the following strange handling of values under defaults section:azure-importer
step, using any of the defaults values for subsequent pipeline steps, causes the numeric values to become.nan
after some calculation.sci-o
afterazure-importer
which expects one of the default value (i.e.grid/carbon-intensity
) as input, pipeline fails stating the below. Also we noticed the input parameterenergy
though configured is not found forsci-o
plug-in.Expected Behaviour
Using
azure-importer
as the first plug-in for our pipeline is a must as it forms the first step of getting source compute/storage info for a particular Azure hosted resource.Hence the expected behavior is, even with
azure-importer
in place, the use of default section values should produce the right output, and also not become "invalid" for subsequent pipeline steps, e.g. in this casegrid/carbon-intensity
parameter is affected.Actual Behaviour
Per what's described in Description of Error items 1 and 2 above,
Steps to Reproduce
For (1), manifest file & result (no pipeline failure but with
.nan
values):For (2), manifest file used:
RESULT: error in pipeline run:
To proof
azure-importer
is indeed causing the issue, commenting out the plug-in in the manifest and emulating its output as input values and re-running it produces the following successful result:Link to online environment
NA
Manifest File That Generated the Error
See above different manifest files trial-and-error.
Links to Any Additional Code
NA
Runtime Info
OS: Windows 10 laptop
IF ver:
+-- @grnsft/[email protected]
+-- @grnsft/[email protected]
`-- @grnsft/[email protected]
The text was updated successfully, but these errors were encountered: