Skip to content

Commit 63abc8c

Browse files
authored
Mark DefaultInheritManifest as internal (#1303)
1 parent 39653ac commit 63abc8c

File tree

5 files changed

+13
-28
lines changed

5 files changed

+13
-28
lines changed

api/shadow.api

-18
Original file line numberDiff line numberDiff line change
@@ -143,24 +143,6 @@ public class com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocat
143143
public fun relocatePath-bvWaKNU (Ljava/lang/String;)Ljava/lang/String;
144144
}
145145

146-
public class com/github/jengelman/gradle/plugins/shadow/tasks/DefaultInheritManifest : com/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest, org/gradle/api/java/archives/Manifest {
147-
public fun <init> (Lorg/gradle/api/internal/file/FileResolver;)V
148-
public fun <init> (Lorg/gradle/api/internal/file/FileResolver;Lorg/gradle/api/java/archives/internal/DefaultManifest;)V
149-
public synthetic fun <init> (Lorg/gradle/api/internal/file/FileResolver;Lorg/gradle/api/java/archives/internal/DefaultManifest;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
150-
public fun attributes (Ljava/util/Map;)Lorg/gradle/api/java/archives/Manifest;
151-
public fun attributes (Ljava/util/Map;Ljava/lang/String;)Lorg/gradle/api/java/archives/Manifest;
152-
public fun from (Ljava/lang/Object;Lgroovy/lang/Closure;)Lorg/gradle/api/java/archives/Manifest;
153-
public fun from (Ljava/lang/Object;Lorg/gradle/api/Action;)Lorg/gradle/api/java/archives/Manifest;
154-
public fun from ([Ljava/lang/Object;)Lorg/gradle/api/java/archives/Manifest;
155-
public fun getAttributes ()Lorg/gradle/api/java/archives/Attributes;
156-
public synthetic fun getEffectiveManifest ()Lorg/gradle/api/java/archives/Manifest;
157-
public fun getEffectiveManifest ()Lorg/gradle/api/java/archives/internal/DefaultManifest;
158-
public fun getSections ()Ljava/util/Map;
159-
public fun inheritFrom ([Ljava/lang/Object;)Lcom/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest;
160-
public fun inheritFrom ([Ljava/lang/Object;Lorg/gradle/api/Action;)Lcom/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest;
161-
public fun writeTo (Ljava/lang/Object;)Lorg/gradle/api/java/archives/Manifest;
162-
}
163-
164146
public abstract interface class com/github/jengelman/gradle/plugins/shadow/tasks/DependencyFilter : java/io/Serializable {
165147
public abstract fun dependency (Ljava/lang/Object;)Lorg/gradle/api/specs/Spec;
166148
public abstract fun dependency (Lorg/gradle/api/artifacts/Dependency;)Lorg/gradle/api/specs/Spec;

lint-baseline.xml

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
errorLine1="import org.gradle.api.internal.file.FileResolver"
88
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
99
<location
10-
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DefaultInheritManifest.kt"
11-
line="4"
10+
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt"
11+
line="5"
1212
column="1"/>
1313
</issue>
1414

@@ -18,8 +18,8 @@
1818
errorLine1="import org.gradle.api.java.archives.internal.DefaultManifest"
1919
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2020
<location
21-
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DefaultInheritManifest.kt"
22-
line="6"
21+
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt"
22+
line="7"
2323
column="1"/>
2424
</issue>
2525

@@ -29,8 +29,8 @@
2929
errorLine1="import org.gradle.api.java.archives.internal.DefaultManifestMergeSpec"
3030
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
3131
<location
32-
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DefaultInheritManifest.kt"
33-
line="7"
32+
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt"
33+
line="8"
3434
column="1"/>
3535
</issue>
3636

@@ -85,7 +85,7 @@
8585
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
8686
<location
8787
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt"
88-
line="32"
88+
line="33"
8989
column="1"/>
9090
</issue>
9191

@@ -96,7 +96,7 @@
9696
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
9797
<location
9898
file="src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt"
99-
line="33"
99+
line="34"
100100
column="1"/>
101101
</issue>
102102

src/docs/changes/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
- **BREAKING CHANGE:** Rename `Transformer` to `ResourceTransformer`. ([#1288](https://github.com/GradleUp/shadow/pull/1288))
1414
Aims to better align with the name of [org.apache.maven.plugins.shade.resource.ResourceTransformer.java](https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/resource/ResourceTransformer.java) and to distinguish itself from [org.gradle.api.Transformer.java](https://docs.gradle.org/current/javadoc/org/gradle/api/Transformer.html).
15+
- **BREAKING CHANGE:** Mark `DefaultInheritManifest` as `internal`. ([#1303](https://github.com/GradleUp/shadow/pull/1303))
1516

1617
**Fixed**
1718

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DefaultInheritManifest.kt src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
package com.github.jengelman.gradle.plugins.shadow.tasks
1+
package com.github.jengelman.gradle.plugins.shadow.internal
22

3+
import com.github.jengelman.gradle.plugins.shadow.tasks.InheritManifest
34
import org.gradle.api.Action
45
import org.gradle.api.internal.file.FileResolver
56
import org.gradle.api.java.archives.Manifest
67
import org.gradle.api.java.archives.internal.DefaultManifest
78
import org.gradle.api.java.archives.internal.DefaultManifestMergeSpec
89

9-
public open class DefaultInheritManifest @JvmOverloads constructor(
10+
internal class DefaultInheritManifest @JvmOverloads constructor(
1011
private val fileResolver: FileResolver,
1112
private val internalManifest: DefaultManifest = DefaultManifest(fileResolver),
1213
) : InheritManifest,

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.github.jengelman.gradle.plugins.shadow.tasks
22

33
import com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin
44
import com.github.jengelman.gradle.plugins.shadow.internal.DefaultDependencyFilter
5+
import com.github.jengelman.gradle.plugins.shadow.internal.DefaultInheritManifest
56
import com.github.jengelman.gradle.plugins.shadow.internal.MinimizeDependencyFilter
67
import com.github.jengelman.gradle.plugins.shadow.internal.UnusedTracker
78
import com.github.jengelman.gradle.plugins.shadow.internal.fileCollection

0 commit comments

Comments
 (0)