Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert templates to upstream and add our own to the custom directory #60

Open
achilleas-k opened this issue Jan 24, 2020 · 0 comments
Open

Comments

@achilleas-k
Copy link
Member

The upside of this is that keeping up to date with upstream is simpler, since it won't create merge conflicts. The downside is that if something changes in the upstream templates with respect to the information they have (variable name change, for instance), it will break our templates without warning.

One solution to the downside is to keep up to date with GOGS more regularly and follow the changes closely, instead of merging blindly.

We could also write tests that check if all pages render properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant