Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add metadata to subgraph options in python #3869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Feb 27, 2025

Fixes: #3866

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (c3591a2) to head (d6869ba).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
daft/dataframe/display.py 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3869      +/-   ##
==========================================
+ Coverage   76.77%   78.35%   +1.57%     
==========================================
  Files         762      763       +1     
  Lines       98616    96744    -1872     
==========================================
+ Hits        75708    75799      +91     
+ Misses      22908    20945    -1963     
Files with missing lines Coverage Δ
daft/dataframe/display.py 32.78% <60.00%> (+0.58%) ⬆️

... and 62 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explaining a query (with format="mermaid", show_all=True, file=f being passed) throws an exception
1 participant