feat(connect): joins

[universalmind303]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging #3849 will not alter performance

_{Comparing universalmind303:connect-joins (127db92) with main (d468589)}

Summary

✅ 24 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 59.34256% with 235 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (d468589) to head (127db92).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/daft-connect/src/spark_analyzer/expr_analyzer.rs	55.31%	63 Missing ⚠️
src/daft-connect/src/spark_analyzer.rs	70.48%	49 Missing ⚠️
src/daft-logical-plan/src/logical_plan.rs	45.45%	42 Missing ⚠️
src/daft-dsl/src/expr/mod.rs	23.07%	10 Missing ⚠️
src/daft-logical-plan/src/ops/set_operations.rs	70.00%	9 Missing ⚠️
src/daft-logical-plan/src/builder/resolve_expr.rs	33.33%	8 Missing ⚠️
src/daft-connect/src/functions.rs	69.23%	4 Missing ⚠️
src/daft-connect/src/functions/math.rs	0.00%	4 Missing ⚠️
src/daft-connect/src/functions/string.rs	0.00%	4 Missing ⚠️
...rc/daft-logical-plan/src/ops/actor_pool_project.rs	20.00%	4 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3849      +/-   ##
==========================================
+ Coverage   78.31%   78.34%   +0.03%     
==========================================
  Files         763      763              
  Lines       96413    96741     +328     
==========================================
+ Hits        75507    75796     +289     
- Misses      20906    20945      +39     

Files with missing lines	Coverage Δ
src/common/daft-config/src/lib.rs	86.25% <ø> (ø)
src/daft-connect/src/functions/aggregate.rs	90.00% <100.00%> (-1.67%)	⬇️
src/daft-logical-plan/src/builder/mod.rs	87.89% <100.00%> (+0.05%)	⬆️
src/daft-logical-plan/src/ops/agg.rs	68.65% <100.00%> (+2.52%)	⬆️
src/daft-logical-plan/src/ops/distinct.rs	94.59% <100.00%> (+0.84%)	⬆️
src/daft-logical-plan/src/ops/filter.rs	86.66% <100.00%> (+1.66%)	⬆️
src/daft-logical-plan/src/ops/join.rs	78.73% <100.00%> (+0.49%)	⬆️
src/daft-logical-plan/src/ops/limit.rs	95.00% <100.00%> (+0.71%)	⬆️
src/daft-logical-plan/src/ops/project.rs	57.34% <100.00%> (+0.43%)	⬆️
src/daft-logical-plan/src/ops/sort.rs	91.93% <100.00%> (+0.70%)	⬆️
... and 23 more

... and 9 files with indirect coverage changes

[kevinzwang]

Looks great! No major comments. Thanks for taking the effort to implement the plan ID stuff

[kevinzwang]

The implementation of this feels a little hacky but we will not need it after we implement non-equi joins anyway so I'm fine with keeping it as is.