Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: SQL temporal functions #2858

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Sep 19, 2024
Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #2858 will degrade performances by 58.51%

Comparing universalmind303:sql-temporals (334310d) with main (53dec06)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-temporals Change
test_count[1 Small File] 9.6 ms 23.1 ms -58.51%
test_show[100 Small Files] 288.3 ms 50.2 ms ×5.7

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a small question on why we have stringify!($fn_name) present in one of the impls for ScalarUdf, but other than that, looks good to me!

@universalmind303 universalmind303 merged commit c5b7062 into Eventual-Inc:main Sep 20, 2024
35 of 36 checks passed
@universalmind303 universalmind303 deleted the sql-temporals branch January 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants