-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow positional placement of endSlot
in TextField
#899
Conversation
@scottlovegrove I feel like there are quite a few edge cases here and it's a bit tricky to find them via Storybook. Could we add a couple of unit tests? (Simple ones like the ones inside |
Storybook issue fixed in #902 |
Short description
This change allows us to use the
bordered
variant ofTextField
and have the endSlot appear centrally, rather than inline with the input at the bottom.Before:

After (with

endSlotPosition
set tofullHeight
:I know Design would like this to be the default behaviour, but given I only need it for one area in the app (new onboarding), I was reluctant to make my changes the default behaviour, so I haven't. This is opt-in, rather than opt-out.
PR Checklist