Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with Android API Level 10 and lower #1

Open
devilmac opened this issue Jun 9, 2014 · 2 comments
Open

Added compatibility with Android API Level 10 and lower #1

devilmac opened this issue Jun 9, 2014 · 2 comments

Comments

@devilmac
Copy link

devilmac commented Jun 9, 2014

Hi DesarrolloAntonio,

this is not an issue but I want to tell you that I modified your library to be compatible with Android 10 and lower, because my project supports at least Android 10 and I want to add fragment transaction animations to it. I'm not able to create a pull request, but the changes done are quite easy and are the following:

  • I added support library v4 for fragments
  • I added library "NineOldAndroid" for support to animations
  • I changed references for Activity with FragmentActivity of the support library in FragmentTransactionExtended class
  • I changed references for all animation classes of Android with the same of NineOldAndroid library, always in FragmentTransactionExtended class

I have not yet tested these changes, but you could tell me if these changes are valid and reasonable.

Kind regards.

Federico

PS: sorry for my english ;)

@devilmac
Copy link
Author

devilmac commented Jun 9, 2014

Hi DesarrolloAntonio,

I hoped that these changes would have to work, but I'm encountering some problem with XML animation's "objectAnimator". I'm trying to create an animation working for Android Level 10 and lower to replace others with "objectAnimator".

@DesarrolloAntonio
Copy link
Owner

Thanks for the contribution, I don't know what is the problem but maybe this library can help:
https://github.com/kedzie/Support_v4_NineOldAndroids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants