-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: never build twice #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new jobserver message to track ongoing compilation tasks, so that duplicates can be completely avoided by re-using the first build task's outcome. This allows de-duplicating builds even if an injected package is already present in the natural dependency closure of the package being built. Fixes #430
4911acb
to
a903aca
Compare
a903aca
to
7a31f03
Compare
eliottness
requested changes
Jan 13, 2025
b82c2b2
to
d817790
Compare
…-dedupe # Conflicts: # internal/cmd/toolexec.go # internal/toolexec/aspect/oncompile.go # internal/toolexec/proxy/compile.go # internal/toolexec/proxy/proxy.go
0bc878b
to
96dc50e
Compare
eliottness
approved these changes
Jan 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
=======================================
Coverage ? 65.00%
=======================================
Files ? 188
Lines ? 11582
Branches ? 0
=======================================
Hits ? 7529
Misses ? 3477
Partials ? 576
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new jobserver message to track ongoing compilation tasks, so that duplicates can be completely avoided by re-using the first build task's outcome. This allows de-duplicating builds even if an injected package is already present in the natural dependency closure of the package being built.
Fixes #430