Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto instrumentation with gorm fails #511

Closed
AlonGluz opened this issue Jan 27, 2025 · 3 comments · Fixed by DataDog/dd-trace-go#3121
Closed

[BUG] Auto instrumentation with gorm fails #511

AlonGluz opened this issue Jan 27, 2025 · 3 comments · Fixed by DataDog/dd-trace-go#3121
Assignees
Labels
bug Something isn't working

Comments

@AlonGluz
Copy link

Version of orchestrion
1.0.3

Describe what happened:
not enough arguments in call to __orchestrion_gorm.Open
have ("gorm.io/gorm".Dialector)
want ("gorm.io/gorm".Dialector, *"gorm.io/gorm".Config, ..."gopkg.in/DataDog/dd-trace-go.v1/contrib/gorm.io/gorm.v1".Option)
exit status 2

Describe what you expected:
For it to work, gorm changed the function interface and *"gorm.io/gorm".Config required.
Steps to reproduce the issue:
build go microservice that utilizes gorm

Additional environment details (Version of Go, Operating System, etc.):
go 1.23
gorm 1.25.12

@AlonGluz AlonGluz added the bug Something isn't working label Jan 27, 2025
@RomainMuller
Copy link
Contributor

Hey!

Thanks for reporting this... Indeed, the standard gorm API does not demand a gorm.Config first argument... but the tracer API we replace it with does... This is an oversight from us.

@AlonGluz
Copy link
Author

So the bug should be fixed when you will merge #512 ?
Appreciate the quick response, I'll //orchestrion:ignore it for now, until you merge it

@RomainMuller
Copy link
Contributor

This should be fixed in v1.0.4 :) Please let us know if that is not the case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants