-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect hidden file attribute #1154
Comments
Seems reasonable to me. It looks like we need to check whether the file attributes contain The one concern I have here is that if this is done naively, it will introduce an additional stat call for every file ripgrep looks at, by default. We should try to avoid that by looking for an existing stat call and reusing its information. |
@BurntSushi thanks for fast response it probably goes without saying, but i am of that opinion that even if this is users should need to opt into this, with the default remaining the faster |
This adds a convenience routine for checking whether file information has the hidden attribute set. This was motivated by this bug report against ripgrep: BurntSushi/ripgrep#1154
currently RipGrep considers a hidden file something starting with
.
, which is along time Linux convention
ripgrep/ignore/src/pathutil.rs
Lines 16 to 24 in c3db8db
However the Windows convention of the hidden file attribute is not recognized by
RipGrep. So if you have some files on Windows with the hidden file attribute,
RipGrep will always show them regardless, unless they also happen to start with
.
The text was updated successfully, but these errors were encountered: