Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber update PRs don't trigger CI #227

Open
ciaranmcnulty opened this issue Feb 17, 2021 · 7 comments
Open

Cucumber update PRs don't trigger CI #227

ciaranmcnulty opened this issue Feb 17, 2021 · 7 comments

Comments

@ciaranmcnulty
Copy link
Contributor

See comment on #222

@stof
Copy link
Member

stof commented Dec 11, 2024

For this to work, the workflow should probably use a dedicated bot account (using an organization-specific github app and authenticating as that app in the workflow) to get a token instead of using the default GHA token (which does not chain triggers when it opens a PR)

@acoulton
Copy link
Contributor

@stof yes, that's my plan when I can get back to this.

One challenge is I don't have access to create / manage a github app for the Behat org, or to configure secrets for github actions. Do you?

The other is that we may need a separate repo to send the PRs from (e.g. Behat/Gherkin-automation-prs) because currently the branch protection rules cover everything so we can't create or delete arbitrary branches in this repo.

@stof
Copy link
Member

stof commented Dec 11, 2024

We would need to work with @ciaranmcnulty or @everzet so that they grant admin access on the organization to active maintainers instead of only write access.

@everzet
Copy link
Member

everzet commented Dec 31, 2024

Sorry for being absent - had mad couple of weeks. @acoulton happy to make you org admin if you're up for it?

@acoulton
Copy link
Contributor

@everzet no need to apologise. Hope you're getting some time to chill over the festive season. That'd be great if you can make me an admin, thanks.

@everzet
Copy link
Member

everzet commented Jan 1, 2025

@acoulton done

@everzet everzet closed this as completed Jan 1, 2025
@acoulton acoulton reopened this Jan 6, 2025
@acoulton
Copy link
Contributor

acoulton commented Jan 6, 2025

@everzet thanks very much for that - I'm just back at work today so will take a look at getting the update flow working again when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants