[DRAFT] Send dispose command for CompositionTarget as an OOB batch #18119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
added
the
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
|
@kekekeks unfortunately this still causes a render pass without a layout pass when the popup closes. 
|
kekekeks
changed the title
3 tasks
|
You can test this PR using the following package version. |
danwalmsley
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a window or popup gets closed we need to make sure that any associated render thread operation have been completed. To do so, we are currently sending a composition batch and waiting for it to complete. However triggering such commit outside of our normal commit scheduling causes some kind of "tearing", as described in #17784
This PR sends a dispose command in a separate small "out-of-baund" batch.