[Grid] Add RowSpacing and ColumnSpacing #18077
Conversation
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
| /// Defines the <see cref="ColumnSpacing"/> property. | ||
| /// </summary> | ||
| public static readonly StyledProperty<double> ColumnSpacingProperty = | ||
| AvaloniaProperty.Register<Grid, double>(nameof(ColumnSpacingProperty)); |
There was a problem hiding this comment.
Would it make sense to add coercion for negative values? Or does UWP support them?
There was a problem hiding this comment.
negative spacing is not recommended feature, but it is supported in uwp/winui3. And so do this PR. This PR support negative spacing, too.
There was a problem hiding this comment.
I also think we should support negative Spacing if possible. It matches with what is allowed for Margin/Padding which can be negative.
There are some rare layout cases it's useful and by default the math usually supports negatives for free.
There was a problem hiding this comment.
Now both the spacing in uwp/winui3 and in these 3 PRs don't support negative values in principle, but in practice they do support (
|
Great work! This has been a nice to have for a long time. |
|
I'm marking this PR with |
MrJul
added
the
needs-api-review
It also matches UWP/WinUI as-is and I've never heard of concerns with that API. |
What does the pull request do?
Add
RowSpacingandColumnSpacingproperties forGrid, just like in UWP and WinUI 3.What is the updated/expected behavior with this PR?
Gridwith various children.RowSpacingandColumnSpacingto non-zero values.How was the solution implemented (if it's not obvious)?
Add the corresponding spacing before calculating the position of each
RowDefinitionorColumnDefinition.Subtract spacing before calculating stars when
GridUnitType=star.Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #5152