Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat dispatcher priorities #17948

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

kekekeks
Copy link
Member

Due to a typo we had aliases instead of separate priorities:

  • AsyncRenderTargetResize was the same as Send (it's a private priority used by X11 platform to queue resize operation ahead of input and rendering)
  • compat priority Normal was the same as BeforeRender (private priority)

Also for some reason the compat DataBind priority was the same as Render while it's supposed to be a separate one.

The effect of this change is X11 window resize being executed after Normal/DataBind jobs and compat DataBind priority actually having its own value that's higher than Render.

This should be a safe change to backport.

@maxkatz6 maxkatz6 added bug backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Jan 11, 2025
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054204-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into master with commit 03f91a2 Jan 11, 2025
12 checks passed
@maxkatz6 maxkatz6 deleted the fixes/fix-compat-priorities branch January 11, 2025 11:00
maxkatz6 pushed a commit that referenced this pull request Feb 15, 2025
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch backported-11.2.x bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants