-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack)!: Split python pack into python and python-ruff #603
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
a3cecdb
to
c9c4337
Compare
This is tentatively ready to come out of draft. @AstroNvim/astrocommunity-maintainers Wanna review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the python-ruff
pack just import the python pack and then add ruff-lsp
? Wouldn't reduce lots of duplicate code
I could do that :) |
So the python pack ends up using stuff such as black and isort, which we dont need in the ruff pack |
The primary point in splitting it is not because people don't want Ruff (though that is a faction), but because isort is made redundant by ruff and because the current config somehow messes up the formatting of imports when they are both present (formatting in the wrong order potentially) So to reuse we would want to be able to remove isort from the python pack at the point of importing it into the ruff pack, which might be unexpected because the user might expect packs to be accumlative. |
Thanks for re-iterating my point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #592