Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack)!: Split python pack into python and python-ruff #603

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Oct 11, 2023

Closes #592

@Uzaaft Uzaaft changed the title feat(pack): Split python pack into python and python-ruff feat(pack)!: Split python pack into python and python-ruff Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 14, 2023

This is tentatively ready to come out of draft. @AstroNvim/astrocommunity-maintainers Wanna review?

@Uzaaft Uzaaft marked this pull request as ready for review October 14, 2023 21:32
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the python-ruff pack just import the python pack and then add ruff-lsp? Wouldn't reduce lots of duplicate code

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 16, 2023

Shouldn't the python-ruff pack just import the python pack and then add ruff-lsp? Wouldn't reduce lots of duplicate code

I could do that :)

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 17, 2023

Shouldn't the python-ruff pack just import the python pack and then add ruff-lsp? Wouldn't reduce lots of duplicate code

So the python pack ends up using stuff such as black and isort, which we dont need in the ruff pack

@m-rutter
Copy link

m-rutter commented Oct 17, 2023

@mehalter

The primary point in splitting it is not because people don't want Ruff (though that is a faction), but because isort is made redundant by ruff and because the current config somehow messes up the formatting of imports when they are both present (formatting in the wrong order potentially)

So to reuse we would want to be able to remove isort from the python pack at the point of importing it into the ruff pack, which might be unexpected because the user might expect packs to be accumlative.

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 17, 2023

The primary point in splitting it is not because people don't want Ruff (though that is a faction), but because isort is made redundant by ruff and because the current config somehow messes up the formatting of imports when they are both present (formatting in the wrong order potentially)

Thanks for re-iterating my point.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzaaft Uzaaft merged commit e0615a4 into main Oct 17, 2023
@Uzaaft Uzaaft deleted the python_split branch October 17, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python pack contains both ruff and isort. Is this necessary
3 participants