Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(python): make sure mason-nvim-dap doesn't set up python debuggers #369

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Jul 5, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter
Copy link
Member Author

mehalter commented Jul 5, 2023

@BillKills974 could you test this out and see if it works? :) This just makes sure that mason-nvim-dap doesn't set up any debuggers automatically and lets nvim-dap-python set it up

Copy link
Contributor

@BillKills974 BillKills974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as advertised in every test I just made.

@mehalter mehalter merged commit eff0d7f into main Jul 5, 2023
@mehalter mehalter deleted the debugpy branch July 5, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants