Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp_lines-nvim): disable plugin in lazy UI #1226

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

RayJameson
Copy link
Contributor

📑 Description

enabled plugin causes diagnostics duplication and looks horrible IMO

ℹ Additional Information

before:
image

after:
image

Copy link

github-actions bot commented Sep 27, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@RayJameson RayJameson marked this pull request as draft September 27, 2024 12:25
@RayJameson RayJameson marked this pull request as ready for review September 27, 2024 12:33
@RayJameson RayJameson force-pushed the fix-lazy-ui branch 6 times, most recently from 484270a to b9db892 Compare September 28, 2024 00:36
enabled plugin causes diagnostics duplication and looks horrible IMO
Copy link
Contributor

@ahmtsen ahmtsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luxus luxus merged commit baeee61 into AstroNvim:main Oct 3, 2024
14 checks passed
@RayJameson RayJameson deleted the fix-lazy-ui branch October 3, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants