Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wishlist] select dataprovider per favorit #336

Open
rlucassen2 opened this issue Feb 18, 2025 · 12 comments
Open

[wishlist] select dataprovider per favorit #336

rlucassen2 opened this issue Feb 18, 2025 · 12 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rlucassen2
Copy link

It would be nice to be able to choose a provider per location (favorits). In France Météo France is preferred, elsewhere OpenWeatherMap. Météo France provides 3 hours interval forecasts outside France while OWM a 1 hour interval.

Just my 2cts,

Richard

@farfromrefug
Copy link
Collaborator

@rlucassen2 it is a great idea. I will.implement it by the end of the year. Sorry I will be on as trip for the next 6 months ans I will only be able.to.do bug fixes

@farfromrefug farfromrefug added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2025
@Mrnofish
Copy link

Yesplease! this Is something i wanted ti suggest too, but held off because of the big break.

@farfromrefug
Copy link
Collaborator

@Mrnofish will come I assure you!
@rlucassen2 OpenWeatherMap will never be the default as it requires an API key. The default will be OpenMeteo outside of France

@Mrnofish
Copy link

Mrnofish commented Feb 24, 2025

Well that was surprising! Do you think we can get favorite renaming too?

It will be useful for location/model pairs.

Also, there are areas where the geocoding always spits out the same name for different locations making it impossible to distinguish.

@farfromrefug
Copy link
Collaborator

@Mrnofish not sure i ll get enough time. But will try!

@Mrnofish
Copy link

BTW for this to be fully functional, the user would need to be able and attach a different Open Meteo model, too, not just the provider.

Since Best Match can be unpredictable/unreliable, you'd likely want to set a US model such as GFS for New York, and a European one like Arpege or Icon for Paris.

@farfromrefug
Copy link
Collaborator

@Mrnofish Indeed. Will be available in the new version i am publishing right now

@0-5-0
Copy link
Contributor

0-5-0 commented Feb 27, 2025

Works great with using multiple models, the only thing I might suggest is possibly a way to duplicate an existing favorite (which can then be renamed/edited), otherwise adding multiple entries of the same location using the search to then select different models gets a bit clunky.

Searching for "Toronto Canada" as an example, then selecting the star to favorite it, if I then search for Toronto Canada (again) to add a second entry so I can select a second model then it's already starred (sees it's already in the favorite) so the only way to add a second entry is going to the "select location on map" option.

It's a bit inconsistent but I've also had instances where when I select the star on a location (after searching for a new location), it adds it to the favorite list and then when I open it from the favorite list the star icon is unselected, if I re-select the star icon it disappears from favorites, if I de-select the star icon it comes back into the favorite list, it's as though it doesn't sync the icon from time to time.

Re-launching the app generally fixes the star icon issue but it happens frequently enough when playing around in the favorites menu or when adding multiple new favorites. Also often with the last added favorite (the one that comes up at the bottom of the list), though sorting that last entry up doesn't seem to change anything (the issue follows the last added favorite).

It's been like that for a few months at least (maybe since always) I just hadn't mentioned it because it sorted itself out from re-launching the app.

@farfromrefug
Copy link
Collaborator

@0-5-0 about the duplicating. Might come in september. About your star issue could you open another issue? Not sure i ll be able to fix it soon though. Only a few days left with a computer

@0-5-0
Copy link
Contributor

0-5-0 commented Feb 27, 2025

Created 2 new issues so that it doesn't keep this issue open. #348 and #347.

Have a great trip :)

@Mrnofish
Copy link

There are a couple cosmetic issues, but otherwise the new features appear to be working as intended.

  • Rename is not capitalized
  • Some text is getting cut

Image

Not major problems in my book, and I'm already feeling guilty about the last rounds of changes, so I'm only bringing them up for future reference.

@farfromrefug
Copy link
Collaborator

@Mrnofish Dont worry! i love to fix every single little issue/detail. You deserve a nice looking weather app !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants