Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2022 #63

Open
monke8555 opened this issue Jun 25, 2021 · 19 comments
Open

VS 2022 #63

monke8555 opened this issue Jun 25, 2021 · 19 comments
Labels
enhancement New feature or request

Comments

@monke8555
Copy link

Is your feature request related to a problem? Please describe:

I got VS 2022, so this extension doesn't work in it. I know it's in preview, but afaik it shouldn't be hard to add support for it.

Solution:

Add VS 2022 support.

@monke8555 monke8555 added the enhancement New feature or request label Jun 25, 2021
@tyllastarr
Copy link

I would like to second this idea.

@1thenikita
Copy link
Owner

Support will be added soon.

@tyllastarr
Copy link

Support will be added soon.

If you need someone to test it, just let me know!

@Kaffu093
Copy link

I'm impatient for this one.

@0xRapidFire
Copy link

Still awaiting for the support.. @1thenikita

@hootanht
Copy link

hootanht commented Nov 9, 2021

@1thenikita please add this extension in vs 2022 extension marketplace soon, we need it

@1thenikita
Copy link
Owner

@1thenikita please add this extension in vs 2022 extension marketplace soon, we need it

Hi. I have begun work on preparing an extension for version 2022. We will try to fix it soon and post the update 😊

@Kaffu093
Copy link

@1thenikita please add this extension in vs 2022 extension marketplace soon, we need it

Hi. I have begun work on preparing an extension for version 2022. We will try to fix it soon and post the update 😊

Nice, thank you!

@ghost
Copy link

ghost commented Dec 4, 2021

When? :)

@PsychoPast
Copy link

Any update?

@hootanht
Copy link

hootanht commented Dec 14, 2021

@tyllastarr waiting ...
please vote for this comment

@rollingmoai
Copy link

rollingmoai commented Dec 23, 2021

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

@1thenikita
Copy link
Owner

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

Because Visual Studio 2019 and older did not work with the extension.

@ghost
Copy link

ghost commented Jan 7, 2022

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

Because Visual Studio 2019 and older did not work with the extension.

Why not create two builds as a workaround?

@rollingmoai
Copy link

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

Because Visual Studio 2019 and older did not work with the extension.

Why not create two builds as a workaround?

Example: VSColorOutput, VSColorOutput64

@1thenikita
Copy link
Owner

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

Because Visual Studio 2019 and older did not work with the extension.

Why not create two builds as a workaround?

Two builds, if I'm not mistaken, cannot be locked into the Visual Studio Marketplace.
And going out, as below, for two extensions, I think is not the best option: you would have to duplicate the code several times, look at different suggestions, why when you can combine in 1 repository?

@ghost
Copy link

ghost commented Jan 7, 2022

@1thenikita It was already merged in #70, why was it reverted 😕 (#76)?

Because Visual Studio 2019 and older did not work with the extension.

Why not create two builds as a workaround?

Two builds, if I'm not mistaken, cannot be locked into the Visual Studio Marketplace. And going out, as below, for two extensions, I think is not the best option: you would have to duplicate the code several times, look at different suggestions, why when you can combine in 1 repository?

Create two marketplace pages for the same repository.

Example:

https://marketplace.visualstudio.com/items?itemName=josefpihrt.Roslynator2019
https://marketplace.visualstudio.com/items?itemName=josefpihrt.Roslynator2022

@ghost
Copy link

ghost commented Jan 7, 2022

I created a (temporary) fork with the changes applied for VS 2022: https://github.com/Majestro000/Visual-Studio
Build with VS 2022 and install by bin\Debug\DiscordRPforVS.vsix

@rollingmoai
Copy link

I created a (temporary) fork with the changes applied for VS 2022: https://github.com/Majestro000/Visual-Studio Build with VS 2022 and install by bin\Debug\DiscordRPforVS.vsix

There is already this fork: https://github.com/CursedSheep/DiscordRPC-Visual-Studio-2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants