Handle break labels like variables. #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset mechanism previously used yielded wrong outputs. For example, `label $x | (def x: break $x; (label $y | x), 0)` yields `0` in jaq 2.1.0, whereas it should yield `empty` (like jq). We replace the offset mechanism completely by a substitution mechanism that assigns break labels a unique index on the current execution path. This uses to a large extent the existing infrastructure for variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset mechanism previously used to deal with
label ... breakyielded wrong outputs in certain situations. For example,label $x | (def x: break $x; (label $y | x), 0)yields0in jaq 2.1.0, whereas it should yieldempty(like jq).This PR replaces the offset mechanism completely by a substitution mechanism that assigns break labels a unique index on the current execution path. This uses to a large extent the existing infrastructure for variables. Consequently, this corrects the execution of
label ... breakexpressions.I discovered this issue while reworking the formal jq specification.